[UR] Plug conformance device tests back into CI - #22733
Merged
Merged
Conversation
kweronsx
force-pushed
the
plug-in-tests
branch
6 times, most recently
from
July 27, 2026 07:21
60a2fa9 to
04d0281
Compare
kweronsx
commented
Jul 28, 2026
kweronsx
commented
Jul 28, 2026
| ur_device_handle_t Dev = nullptr; | ||
| for (const auto &p : GlobalAdapter->Platforms) { | ||
| Dev = p->getDeviceFromNativeHandle(ZeDevice); | ||
| if (auto devHandle = p->getDeviceFromNativeHandle(ZeDevice); devHandle) |
Contributor
Author
There was a problem hiding this comment.
This fragment was updated, because, on one of the test setups, the last iteration assigned nullptr to the 'Dev' variable causing the test to fail. Therefore, with this change, we preserve the preference to select the last device, but we also make sure it is not null.
kswiecicki
approved these changes
Jul 28, 2026
kweronsx
force-pushed
the
plug-in-tests
branch
2 times, most recently
from
July 29, 2026 10:47
f67f7a0 to
f8e568d
Compare
kweronsx
commented
Jul 29, 2026
| if (FanCount == 0) | ||
| return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION; | ||
|
|
||
| if (!ParamValue) { |
Contributor
Author
There was a problem hiding this comment.
Early exit in the test when ParamValue == nullptr hid that the query is not supported.
kweronsx
commented
Jul 29, 2026
| for (auto Fan : ZeFanHandles) { | ||
| int32_t CurSpeed; | ||
| ZE2UR_CALL(zesFanGetState, (Fan, ZES_FAN_SPEED_UNITS_PERCENT, &CurSpeed)); | ||
| auto result = ze2urResult(ZE_CALL_NOCHECK( |
Contributor
Author
There was a problem hiding this comment.
I'm also remapping the return value as the macro (ASSERT_SUCCESS_OR_OPTIONAL_QUERY) checks against UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION.
cperkinsintel
approved these changes
Jul 29, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please consider merging. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22025